Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RELEASE.md notes for branch builds #290

Merged
merged 3 commits into from
Nov 15, 2017
Merged

RELEASE.md notes for branch builds #290

merged 3 commits into from
Nov 15, 2017

Conversation

chrisplo
Copy link
Contributor

@chrisplo chrisplo commented Nov 6, 2017

No description provided.

@chrisplo
Copy link
Contributor Author

chrisplo commented Nov 6, 2017

Example:

NETPLUGIN_BRANCH=v2plugin_local_versioned NETPLUGIN_OWNER=chrisplo make build

$ ls -l contiv-devbuild/contiv_cache/netplugin-*
-rw-r--r--  1 chrisplo  staff  20887462 Nov  6 11:15 contiv-devbuild/contiv_cache/netplugin-ca1b582.tar.bz2
lrwxr-xr-x  1 chrisplo  staff        25 Nov  6 11:14 contiv-devbuild/contiv_cache/netplugin-chrisplo-v2plugin_local_versioned.tar.bz2 -> netplugin-ca1b582.tar.bz2

dseevr
dseevr reviewed Nov 8, 2017
View reviewed changes
Copy link
Contributor

@dseevr dseevr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you maybe add an example invocation?

RELEASE.md Outdated
# Testing installer builds of any netplugin branch
To create a full installer for legacy docker swarm of any branch of contiv, additionally set these two environment variables:

* NETPLUGIN_BRANCH - the branch to compile instead of latest release
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this "branch to compile instead of current branch"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is not set, install pulls release versions only based on a checked in variable value or environment override, which is unrelated to any workspace branch

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the description be something more like that? The current text didn't imply any of that to me as someone reading it for the first time

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@kahou82
Copy link
Member

kahou82 commented Nov 15, 2017

👍

@chrisplo chrisplo merged commit 9d8f267 into contiv:master Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dseevr dseevr dseevr approved these changes

Assignees
No one assigned
Labels
squash merge only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisplo @kahou82 @dseevr